]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
appDisplay: Return false in acceptDrop when not accepting the drop
authorJonas Dreßler <verdre@v0yd.nl>
Mon, 3 Aug 2020 19:47:42 +0000 (21:47 +0200)
committerFlorian Müllner <florian.muellner@gmail.com>
Mon, 3 Aug 2020 21:48:44 +0000 (21:48 +0000)
Fix what is probably a copy-paste error and return false instead of a
CONTINUE DragMotionResult which is only meant for dragMotion events, not
drop events. This makes sure we don't create a folder when dropping an
app over the drag leeways of another icon.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1389

js/ui/appDisplay.js

index 861db5d5ab54fb954484e3cced94a094d8cb7816..1c25dfe39b35ffb3de55d089163195d0a102d48d 100644 (file)
@@ -1541,7 +1541,7 @@ class AppViewItem extends St.Button {
             return false;
 
         if (this._withinLeeways(x))
-            return DND.DragMotionResult.CONTINUE;
+            return false;
 
         return true;
     }